> Dietmar Maurer <diet...@proxmox.com> hat am 12. April 2018 um 11:11
> geschrieben:
>
>
> > @@ -293,12 +303,16 @@ sub replicate {
> > die $err;
> > }
> >
> > - # remove old snapshots because they are no longer needed
> > - $cleanup_local_snapshots->($last_snapshots, $last_sync_snapname);
> > + eval {
> > + # remove old snapshots because they are no longer needed
> > + $cleanup_local_snapshots->($last_snapshots, $last_sync_snapname);
>
> Seems to me that $cleanup_local_snapshots->() never raise an exception, so
> this
> code does not
> really makes sense? At least there is no need to catch errors from
> $cleanup_local_snapshots ?
This is true.
Only
remote_finalize_local_job($ssh_info, $jobid, $vmid, $sorted_volids,
$start_time, $logfunc);
has to be catched.
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
