On 9/19/18 11:35 AM, Dominik Csapak wrote:
> this adds a VM Generation ID device uses by Windows (Server) to determine
> some specific actions that may have happened with the vm
> such as rollback, restore, etc.
> 
> see:
> 
> https://docs.microsoft.com/en-us/windows/desktop/hyperv_v2/virtual-machine-generation-identifier
> 
> for details on how it works and when it should change
> 
> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
> ---
> changes from v2:
> * drop the property string, use uuid directly (or 1/0)
> * autogenerate in the api during create/set instead of during vm start
>   (writing it manually to 1 in the config leads to an error, but this is
>   expected, users should use the api or qm)
> 

applied thanks, added a verbose_description (nice for the online docs) a
comment for the rollback case and used 'vmgenid' directly instead of the
$1 when restoring a backup, code is easier to read and safeguarded against
a accidental regex insertion between matching vmgenid and printing it out
to the new conf file.


_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to