On 6/3/20 4:35 PM, Thomas Lamprecht wrote:
On 5/4/20 4:08 PM, Aaron Lauterer wrote:
[...]
+sub get_included_guests {
+ my ($self, $job) = @_;
do we need $self here? Why not call it like:
PVE::VZDump::get_included_guests($params) ?
You're right. No need for it AFAICT
+
+ my $nodename = PVE::INotify::nodename();
+ my $vmids = [];
+
+ # convert string lists to arrays
+ if ($job->{pool}) {
+ $vmids = PVE::API2Tools::get_resource_pool_guest_members($job->{pool});
You use API2Tools here but do not add it as module use statement.
Thanks for catching that.
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
