Hi Julian,
Yup, you are right. We will fix this in the next release.
There are a couple of places where I had noticed this sort of thing.
Thanks for pointing it out,
Murali
On Sun, 20 Nov 2005, Julian Martin Kunkel wrote:
> Hi,
>
> The error occurs only on immediate completion of trove_dspace_verify and if
> the handle does not exist then trove_dspace_verify returns -TROVE_ENOENT this
> should be returned to the client because the client does not understand
> -EINVAL ! In the function job_trove_dspace_verify is already a TODO note :)
>
> Old code:
> if (ret < 0)
> {
> /* error posting trove operation */
> JOB_EVENT_END(PVFS_EVENT_TROVE_DSPACE_VERIFY, 0, jd->job_id);
> dealloc_job_desc(jd);
> jd = NULL;
> /* TODO: handle this correctly */
> out_status_p->error_code = -EINVAL;
> out_status_p->status_user_tag = status_user_tag;
> return (1);
> }
>
> Just change the line to: out_status_p->error_code = ret;
> Then the trove_method might decide which error value should be returned...
>
> Have a nice day
> Julian
> _______________________________________________
> PVFS2-developers mailing list
> [EMAIL PROTECTED]
> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>
>
_______________________________________________
PVFS2-developers mailing list
[EMAIL PROTECTED]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
