msgpair-gossip-svr.patch:
--------------------------
This is a small patch that just changes the error message in
msgpairarray that gets printed if an operation fails. It attempts to
print the name of the server that communication fails to if possible,
and gives a little bit more indication of why we gave up on the msgpair.
It is helpful in identifying problematic servers.
pvfs2-verbose-mask.patch:
--------------------------
This is a trivial patch. It changes the "verbose" debugging mask so
that it once again includes request scheduler debugging. The reason
reqsched was left out in the past was because it would generate logging
messages very frequently even on idle servers (and therefore clutter the
log files), but that is not the case anymore. After this patch,
"verbose" and "all" are the same. As a side note, the verbose mask is
still handy to have on hand- I already have another patch on the way
that will add another mask that is too chatty for normal consumption :)
pvfs2-client-fds.patch:
--------------------------
This patch was originally posted here:
http://www.beowulf-underground.org/pipermail/pvfs2-developers/2005-November/001609.html
I am including it again because it sortof fits in with these other
patches in that it adjusts how error messages are displayed.
-Phil
diff -Naur pvfs2-one/src/common/misc/msgpairarray.sm pvfs2-two/src/common/misc/msgpairarray.sm
--- pvfs2-one/src/common/misc/msgpairarray.sm 2005-08-01 17:12:01.000000000 +0200
+++ pvfs2-two/src/common/misc/msgpairarray.sm 2005-11-11 19:23:14.000000000 +0100
@@ -487,6 +487,9 @@
int ret = -PVFS_EINVAL, i = 0;
int need_retry = 0;
struct PINT_decoded_msg decoded_resp;
+ const char* server_string = NULL;
+ struct server_configuration_s *server_config = NULL;
+ int server_type;
/* response structure (decoded) */
struct PVFS_server_resp *resp_p = NULL;
@@ -627,9 +630,33 @@
} else {
char s[1024];
+ server_config = PINT_server_config_mgr_get_config(msg_p->fs_id);
+ if(server_config)
+ {
+ server_string = PINT_cached_config_map_addr(
+ server_config, msg_p->fs_id, msg_p->svr_addr, &server_type);
+ PINT_server_config_mgr_put_config(server_config);
+ }
+ else
+ {
+ server_string = "[UNKNOWN]";
+ }
PVFS_strerror_r(msg_p->op_status, s, sizeof(s));
- gossip_err("*** %s: msgpair failed, no retry: %s\n",
- __func__, s);
+ gossip_err("*** %s: msgpair to server %s failed: %s\n",
+ __func__, server_string, s);
+ if(msg_p->retry_flag != PVFS_MSGPAIR_RETRY)
+ {
+ gossip_err("*** No retries requested.\n");
+ }
+ else if(PVFS_ERROR_CLASS(-msg_p->op_status) !=
+ PVFS_ERROR_BMI)
+ {
+ gossip_err("*** Non-BMI failure.\n");
+ }
+ else
+ {
+ gossip_err("*** Out of retries.\n");
+ }
if (js_p->error_code == 0)
js_p->error_code = msg_p->op_status;
}
---------------------
PatchSet 312
Date: 2005/11/29 21:47:12
Author: pcarns
Branch: HEAD
Tag: (none)
Log:
added request scheduler debugging mask back into the "verbose" mask; the
request scheduler no longer generates continuous messages on idle servers
[task7444]
Members:
src/common/misc/pvfs2-debug.c:1.5->1.6
Index: src/common/misc/pvfs2-debug.c
diff -u src/common/misc/pvfs2-debug.c:1.5 src/common/misc/pvfs2-debug.c:1.6
--- src/common/misc/pvfs2-debug.c:1.5 Wed Nov 2 07:46:09 2005
+++ src/common/misc/pvfs2-debug.c Tue Nov 29 14:47:12 2005
@@ -72,7 +72,7 @@
{ "access", GOSSIP_ACCESS_DEBUG },
{ "access_detail", GOSSIP_ACCESS_DETAIL_DEBUG },
{ "listeattr", GOSSIP_LISTEATTR_DEBUG },
- { "verbose", (__DEBUG_ALL & ~GOSSIP_REQ_SCHED_DEBUG)},
+ { "verbose", (__DEBUG_ALL)},
{ "none", GOSSIP_NO_DEBUG },
{ "all", __DEBUG_ALL }
};
---------------------
PatchSet 244
Date: 2005/10/27 23:08:54
Author: pcarns
Branch: HEAD
Tag: (none)
Log:
moved freopen() calls to pvfs2-client-core rather than pvfs2-client, so that
we have a chance to see any exec errors on stderr before gossip takes over
[artf24868]
Members:
src/apps/kernel/linux/pvfs2-client-core.c:1.11->1.12
src/apps/kernel/linux/pvfs2-client.c:1.5->1.6
Index: src/apps/kernel/linux/pvfs2-client-core.c
diff -u src/apps/kernel/linux/pvfs2-client-core.c:1.11 src/apps/kernel/linux/pvfs2-client-core.c:1.12
--- src/apps/kernel/linux/pvfs2-client-core.c:1.11 Tue Oct 25 13:52:45 2005
+++ src/apps/kernel/linux/pvfs2-client-core.c Thu Oct 27 16:08:54 2005
@@ -2284,6 +2284,10 @@
fprintf(stderr, "Error opening logfile: %s\n", s_opts.logfile);
return(ret);
}
+ /* get rid of stdout/stderr/stdin */
+ freopen("/dev/null", "r", stdin);
+ freopen("/dev/null", "w", stdout);
+ freopen("/dev/null", "w", stderr);
start_time = time(NULL);
local_time = localtime(&start_time);
Index: src/apps/kernel/linux/pvfs2-client.c
diff -u src/apps/kernel/linux/pvfs2-client.c:1.5 src/apps/kernel/linux/pvfs2-client.c:1.6
--- src/apps/kernel/linux/pvfs2-client.c:1.5 Wed Aug 24 10:27:29 2005
+++ src/apps/kernel/linux/pvfs2-client.c Thu Oct 27 16:08:54 2005
@@ -93,10 +93,6 @@
{
exit(1);
}
- /* get rid of stdout/stderr/stdin */
- freopen("/dev/null", "r", stdin);
- freopen("/dev/null", "w", stdout);
- freopen("/dev/null", "w", stderr);
}
return monitor_pvfs2_client(&opts);
}
---------------------
PatchSet 255
Date: 2005/11/01 14:59:31
Author: pcarns
Branch: HEAD
Tag: (none)
Log:
bug fix: close std file descriptors on monitoring process
[artf24868]
Members:
src/apps/kernel/linux/pvfs2-client.c:1.8->1.9
Index: src/apps/kernel/linux/pvfs2-client.c
diff -u src/apps/kernel/linux/pvfs2-client.c:1.8 src/apps/kernel/linux/pvfs2-client.c:1.9
--- src/apps/kernel/linux/pvfs2-client.c:1.8 Fri Oct 28 08:34:35 2005
+++ src/apps/kernel/linux/pvfs2-client.c Tue Nov 1 07:59:31 2005
@@ -163,6 +163,11 @@
printf("Waiting on child with pid %d\n", (int)new_pid);
}
+ /* get rid of stdout/stderr/stdin */
+ freopen("/dev/null", "r", stdin);
+ freopen("/dev/null", "w", stdout);
+ freopen("/dev/null", "w", stderr);
+
wpid = waitpid(new_pid, &ret, 0);
assert(wpid != -1);
_______________________________________________
PVFS2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
