Ok, one more update. I think this is just a hiccup from the merge
process. Line 441 of sys-getattr.sm looks like this:
----------------------------------------------
gossip_debug(GOSSIP_ACACHE_DEBUG, "acache: acache miss due to mask: "
" [%llu]\n",
llu(object_ref.handle));
return 1;
-----------------------------------------------
but it should really be like this:
-----------------------------------------------
gossip_debug(GOSSIP_ACACHE_DEBUG, "acache: acache miss due to mask: "
" [%llu]\n",
llu(object_ref.handle));
js_p->error_code = GETATTR_ACACHE_MISS;
return 1;
-----------------------------------------------
This was causing cache lookups to succeed sometimes when not all of the
attributes were present. This showed up when trying to untar a big
tarball onto pvfs2 with the acache enabled.
-Phil
Phil Carns wrote:
Great- thanks for sorting that out! I will also do some testing against
the current CVS tree to make sure everything looks ok on my end.
In the mean time, I have one more patch (attached). This fixes a memory
leak in the patches that I submitted earlier. It only shows up when the
acache is disabled.
-Phil
Sam Lang wrote:
I've committed these perf counter and acache changes with only a few
mods to work with the small I/O and changes and bring it up to date
with trunk (we use llu() instead of Lu() now, for example). I've
attached the diff of the entire changes I've committed.
_______________________________________________
PVFS2-developers mailing list
PVFS2-developers@beowulf-underground.org
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
