Pete,

It appears that compile errors I'm running into with PVFS2 and Silverstorm/Mellanox infiniband are definitions in the ib code that duplicate definitions in kernel headers. Specifically:

#define likely(x)       __builtin_expect(!!(x), 1)
#define unlikely(x)     __builtin_expect(!!(x), 0)

  Do you think it may be appropriate to call these

PVFS2_likely and PVFS2_unlikely to avoid name collisions with kernel #defines? We could also test for their existince, though then we couldn't be certain what the macro did exactly. Any strong opinions?

Cheers,
Brad

Pete Wyckoff wrote:
[EMAIL PROTECTED] wrote on Tue, 14 Feb 2006 12:01 -0500:

[EMAIL PROTECTED] wrote on Tue, 14 Feb 2006 11:15 -0500:

[..]

But I see your include dirs are separate from your libs, so we
really should break this out into two separate checks.  But in
the mean time you can continue your workaround with CFLAGS, but edit
Makefile.in, grep for IBLIBS, and change /lib to /lib64 for now.
I'll work on more resilient configurations if this seems to work.


I just checked in the attached patch.  With it you should
be able to do:

    --with-ib-includes=/usr/include/iba/vapi
    --with-ib-libs=/lib64

and get it to build without CFLAGS or code changes.  Modulo anything
else weird in the SilverStorm code.

                -- Pete
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers

Reply via email to