[EMAIL PROTECTED] wrote on Wed, 10 May 2006 11:00 -0400:
> Somehow you bumped the server to send a response. No idea why it
> waited until now to respond. A server-side trace would help.
I think I fixed it. At least my failing test case here seems to
be fixed. Try the attached patch (that got put into CVS already).
I'll push similar into openib as well.
-- Pete
--- Begin Message ---
Update of /projects/cvsroot/pvfs2/src/io/bmi/bmi_ib
In directory parlweb1:/tmp/cvs-serv14703/src/io/bmi/bmi_ib
Modified Files:
ib.c
Log Message:
fix interface mutex deadlock on server; avoid coredump for name lookup on
unconnected peers
Index: ib.c
===================================================================
RCS file: /projects/cvsroot/pvfs2/src/io/bmi/bmi_ib/ib.c,v
diff -u -p -p -u -r1.25 -r1.26
--- ib.c 6 Apr 2006 14:39:36 -0000 1.25
+++ ib.c 10 May 2006 17:07:55 -0000 1.26
@@ -5,7 +5,7 @@
*
* See COPYING in top-level directory.
*
- * $Id: ib.c,v 1.25 2006/04/06 14:39:36 pw Exp $
+ * $Id: ib.c,v 1.26 2006/05/10 17:07:55 pw Exp $
*/
#include <stdio.h> /* just for NULL for id-generator.h */
#include <stdlib.h>
@@ -1413,6 +1413,10 @@ BMI_ib_testcontext(int incount, bmi_op_i
up = &user_ptrs[n];
n += test_rq(rq, &outids[n], &errs[n], &sizes[n], up, complete);
}
+
+ /* drop lock before blocking on new connections below */
+ gen_mutex_unlock(&interface_mutex);
+
*outcount = n;
if (n > 0) {
gettimeofday(&last_action, 0);
@@ -1436,7 +1440,6 @@ BMI_ib_testcontext(int incount, bmi_op_i
gettimeofday(&last_action, 0);
}
}
- gen_mutex_unlock(&interface_mutex);
return 0;
}
@@ -1637,7 +1640,10 @@ static const char *
BMI_ib_rev_lookup(struct method_addr *meth)
{
ib_method_addr_t *ibmap = meth->method_data;
- return ibmap->c->peername;
+ if (!ibmap->c)
+ return "(unconnected)";
+ else
+ return ibmap->c->peername;
}
/* exported method interface */
_______________________________________________
Pvfs2-cvs mailing list
[EMAIL PROTECTED]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-cvs
--- End Message ---
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
