Thanks for the patches. tracking down these bugs can be a big pain. good job, man. just a few questions.
On Thu, May 18, 2006 at 03:44:28PM -0600, Avery Ching wrote: > small_io_total_bytes_fix.patch: > > Fixed an issue with the small I/O total size being passed to the > trove_bstream_write_list(). The uint32_t was being casted to > (TROVE_size *)&s_op->req->u.small_io.total_bytes on line 162 of > small_io.sm. If you are going to change the type of 'total_bytes', don't forget you'll have to change the encode_PVFS_servreq_small_io and decode_PVFS_servreq_small_io macros, too. > process_multiple_aiocbs.patch: > > Fixed the dbpf_bstream_listio_convert() function to actually handle more > than a single aiocb at a time. This should boost noncontiguous I/O > performance quite a bit. Can you help me understand why your changes work? What is making the existing code return too early? I'm not saying you did it wrong, of course. it's just code i don't know very well. ==rob -- Rob Latham Mathematics and Computer Science Division A215 0178 EA2D B059 8CDF Argonne National Labs, IL USA B29D F333 664A 4280 315B _______________________________________________ Pvfs2-developers mailing list [email protected] http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
