On Jun 12, 2006, at 8:45 PM, Sam Lang wrote:
On Jun 12, 2006, at 3:55 PM, Bradley W Settlemyer wrote:
Is there a strong reason not to #define these strings somewhere?
I don't think so. Making them #defines would mean either replacing
the strings in the array with the defs, or creating the structs
dynamically. I think sizeof on an inlined string gives the length
of the string, so we might be able to do something like:
#define METAFILE_DIST "md"
Trove_Common_Keys[] =
{
{METAFILE_DIST, sizeof(METAFILE_DIST)},
...
}
I went ahead and committed these changes, hopefully they will prevent
similar bugs in the future. The #define strings are located in pvfs2-
internal.h.
Also, I removed the lines from genconfig that output the
AttrCacheKeywords options to the config file. The default is already
set to the values that were being output, and I don't see these
options as something most users would want to change (or something we
would want them to know about). The same with AttrCacheSize and
AttrCacheMaxNumElems. Users can still add non-default values to the
config file if they wish.
-sam
BTW, the reason I changed all the strings to two characters:
Julian found that it would reduce the size of the keyval berkeley
db on disk by about 10%.
-sam
Cheers,
Brad
Sam Lang wrote:
I missed a keyval string in mkspace.c. I've committed a fix
which seems to allow ls to work properly now.
-sam
On Jun 12, 2006, at 3:26 PM, Sam Lang wrote:
Hmm...doesn't work for me either. I'll keep debugging.
-sam
On Jun 12, 2006, at 3:19 PM, Bradley W Settlemyer wrote:
It no longer core dumps when I do a pvfs2-ls on a freshly
created filesystem, but I still cannot get pvfs2-ls to
function on a just created file system.
Is it me or you?
Cheers,
brad
Sam Lang wrote:
Brad,
I think this was caused by a commit that I made last week to
set shorten the keyval strings. I had the wrong values for
the lengths. I've committed a fix, can you update and try
again?
-sam
On Jun 12, 2006, at 2:38 PM, Bradley W Settlemyer wrote:
I'm not certain whether its something I've done or what, but
it's pretty screwed up. I just did a pvfs2-ls, and got this:
software/pvfs2/bin/pvfs2-ls /parl/bradles/software/pvfs2/mnt/
PVFS_sys_readdir: Invalid argument
My attributes are totally hosed, here is the server:
[D 06/12 15:34] (0x929a468) getconfig (prelude sm) state:
req_sched
[D 06/12 15:34] (0x929a468) getconfig (prelude sm) state:
getattr_if_needed
[D 06/12 15:34] (0x929a468) getconfig (prelude sm) state:
perm_check (status = 0)
[D 06/12 15:34] (0x929a468) getconfig (FR sm) state:
release: (error_code = 0)
[D 06/12 15:34] (0x929a468) getconfig (FR sm) state:
send_resp (status = 0)
[D 06/12 15:34] (0x929a468) getconfig (FR sm) state: cleanup
[D 06/12 15:34] (0x929b498) getattr (prelude sm) state:
req_sched
[D 06/12 15:34] (0x929b498) getattr (prelude sm) state:
getattr_if_needed
[D 06/12 15:34] About to retrieve attributes for handle 1048576
[D 06/12 15:34] (0x929b498) getattr (prelude sm) state:
perm_check (status = 0)
[D 06/12 15:34] (0x929b498) getattr (FR sm) state: release:
(error_code = -1073742095)
[D 06/12 15:34] (0x929b498) getattr (FR sm) state:
send_resp (status = -1073741839)
[D 06/12 15:34] (0x929b498) getattr (FR sm) state: cleanup
[D 06/12 15:34] (0x929c4c8) getattr (prelude sm) state:
req_sched
[D 06/12 15:34] (0x929c4c8) getattr (prelude sm) state:
getattr_if_needed
[D 06/12 15:34] About to retrieve attributes for handle 1048576
[D 06/12 15:34] (0x929c4c8) getattr (prelude sm) state:
perm_check (status = 0)
[D 06/12 15:34] (0x929c4c8) getattr (FR sm) state: release:
(error_code = -1073742095)
[D 06/12 15:34] (0x929c4c8) getattr (FR sm) state:
send_resp (status = -1073741839)
[D 06/12 15:34] (0x929c4c8) getattr (FR sm) state: cleanup
That release error code is the "invalid argument" error code.
Cheers,
brad
Sam Lang wrote:
Are you using a previously created storage space? When was
the last time you did a cvs update? The storage format
has changed, so if its been a while since you updated,
you may need to run the migration tool or re-create your
storage spaces.
I can't think of anything else that would bite you...the
nightly tests seem to have passed last night...
-sam
On Jun 12, 2006, at 2:03 PM, Bradley W Settlemyer wrote:
I just did a cvs update this morning, not having much luck
with the filesystem.
Is pvfs2-cp or pvfs2-touch working for anyone else at the
moment? Create is returning me an invalid argument problem.
[D 14:58:55.314670] Handle created: 4294967297
[D 14:58:55.314828] (0x86a2f10) create (FR sm) state:
release: (error_code = 0)
[D 14:58:55.314875] (0x86a2f10) create (FR sm) state:
send_resp (status = 0)
[D 14:58:55.315046] (0x86a2f10) create (FR sm) state: cleanup
[D 14:58:55.320648] (0x86a3f40) setattr (prelude sm)
state: req_sched
[D 14:58:55.320793] (0x86a3f40) setattr (prelude sm)
state: getattr_if_needed
[D 14:58:55.320821] About to retrieve attributes for
handle 1048574
[D 14:58:55.320866] (0x86a3f40) setattr (prelude sm)
state: perm_check (status = 0)
[D 14:58:55.320932] (0x86a3f40) setattr (FR sm) state:
release: (error_code = -1073742095)
[D 14:58:55.320968] (0x86a3f40) setattr (FR sm) state:
send_resp (status = -1073741839)
[D 14:58:55.321064] (0x86a3f40) setattr (FR sm) state: cleanup
Cheers,
Brad
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-
developers
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-
developers
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
