On Jun 15, 2006, at 4:37 PM, Rob Ross wrote:

aren't we supposed to be converting the BDB error codes to our own somewhere?


Yeah there's a dbpf_db_error_to_trove_error func that gets used most places. Not sure why its not getting used there...

Sam Lang wrote:
Also, the dbpf_open_cache_get/put stuff at the top of getattr_op_svc can be removed.

I take that back. It does a stat on the bstream to get the size of the datafile. I think we only want to do that if the handle really is a datafile though. Also if the bstream doesn't exist we want the b_size to be set to 0, but that's what it gets initialized to, which is why the block is empty. I'll move the init to 0 into the error block so that it doesn't confuse me in the future.

-sam

We don't use the open cache in the dspace code anymore. Not sure why the error block was empty though, it would be nice if - Wall would warn about that.
-sam
        -- Pete
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers

_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers


_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers

Reply via email to