Yeah, I did that because I figured it would provide continuity. Then I
decided it was ugly for exactly the reason you stated and changed it.
Then decided the union was a pain in the ass and dropped it in favor of
a void pointer. :-)
Walt
Sam Lang wrote:
Hi Walt,
The state machine stuff you've got in WALT3 branch looks like its coming
along. Nice to see those cleanups to the state_machine functions. I
have a minor nit about this:
/* Op State - this is the user-specific (client or server) information
* that must be maintained for each running state machine - if new
* "users" are created the need to be added to this union
*/
union PINT_OP_STATE
{
struct PINT_server_op s; /* server specific fields */
struct PINT_client_sm c; /* client specific fields */
};
The caps makes me think of #define, which I think it used to be. Could
that be PINT_op_state instead? Or is this the union that is going to be
replaced with a void*?
-sam
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
