On Jul 20, 2006, at 10:48 AM, Julian Martin Kunkel wrote:
Hi,
I would prefer to have another check, too.
The problem I had was that in the way the DB_AUTO_COMMIT is used
was that it
did not work with another 4.3 db self compiled version
I think with 4.3, DB_AUTO_COMMIT isn't supposed to work the way
you're using it currently (by passing it to just the open call). For
4.3 and earlier, we would need to pass it to each of the individual
db->put calls. The website's 4.4 documentation about DB_AUTO_COMMIT
suggests that the flag is just ignored now when its passed to db-
>put, so I was voting for passing it to all the db->put calls as
well, which should take care of previous versions as well as newer ones.
, maybe because db was
compiled wrong ?
For now until it is tested with different distros and versions I
would say it
might be good to keep the test. If we find out that there is no
problem with
it we can reduce the testcase. I just want to make sure that it
really works
if it is supposed to work.
#ifdef in pvfs2-server.c
I added it because the db error might be missleading, when I saw
the db error
on my own db 4.2 it was totally nonsens. So I thought the extra
test really
shows whats going on for the people :)
Again, I aggree with you, if it turns out that it works and that
the error
code from db is meaningful then we can strip it out easily. For
testing
purpose on other distros and versions I would prefer to keep it to
reduce the
number of people asking why it fails...
Well this certainly is more user friendly. I'd prefer to see our
code use DB_AUTO_COMMIT so that previous 4.x versions of db work for
transaction mode as well, and we don't have to add this check.
-sam
Julian
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
