[EMAIL PROTECTED] wrote on Fri, 18 Aug 2006 22:50 +0200:
> I attached a patch which adds PVFS_hint to most system interface calls,
> these hints can be used on the client side only or are automatically
> transfered to the server if a flag is set in the hint_transfer_to_server
> array for the appropriate hint. The hint itself consists of a number (hint
> type int32_t) and a variable string.
I don't like having a PVFS_hint argument on every sysint call.
Seems like some selectivity would be warranted. What kind of hint
will one ever want to pass to PVFS_mgmt_noop() for instance?
But I'll let others say if they think this is the way to go.
Weren't you just wanting to generate a custom distribution that
kept your file on a single host? I thought that was possible
already.
(Looks like some random aio hacking crept into this patch too.)
> Therefore the size of the fixed request protocoll becomes dynamic, I hope
> this
> will work and that there are no problems with it, maybe the union structure
> in the request protocoll has to be padded to be 4 byte aligned ?
> However, to control this structure I added a maximum value which limits the
> maximum number of bytes in the hint structure.
Can you use the existing encode_string and decode_string here? Grep
for "string," in src/proto/pvfs2-req-proto.h to see how other
structs use it. Your functions seem to replicate that code.
Since you just tacked on after credentials, presumably someone
already thought of the aligment between the unions and the
credentials. Then you're okay as credentials occupy an even 8 bytes.
-- Pete
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
