[EMAIL PROTECTED] wrote on Thu, 13 Mar 2008 10:15 -0500:
> Update of /projects/cvsroot/pvfs2-1/src/kernel/linux-2.6
> In directory parlweb1:/tmp/cvs-serv2461/src/kernel/linux-2.6
>
> Modified Files:
> pvfs2-proc.c
> Log Message:
> around 2.6.24 the '0' termination stopped working. good news is that we can
> 0-terminate on 2.4 and ctl_name terminate on 2.6
>
>
> Index: pvfs2-proc.c
> ===================================================================
> RCS file: /projects/cvsroot/pvfs2-1/src/kernel/linux-2.6/pvfs2-proc.c,v
> diff -u -w -p -u -r1.10 -r1.11
> --- pvfs2-proc.c 6 Mar 2008 20:40:59 -0000 1.10
> +++ pvfs2-proc.c 13 Mar 2008 15:15:55 -0000 1.11
> @@ -327,7 +327,11 @@ static ctl_table pvfs2_acache_table[] =
> .proc_handler = &pvfs2_param_proc_handler,
> .extra1 = &acache_rec_extra,
> },
> +#ifdef PVFS2_LINUX_KERNEL_2_4
> {0}
> +#else
> + {.ctl_name = 0}
> +#endif
These should be exactly identical. .ctl_name is the first entry
in the structure.
Kernel auto-initializes all static variables to zero. Preferred
form for the above is thus actually:
{}
(You can grep around to see it.) Not sure if 2.4 is unhappy with
that.
The kernel module has been working for me on 2.6.25-rc4. Is there
some error case I can test to see the problem?
I think ifdefs are ugly.
-- Pete
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
