Looks good to me.
The only minor thing I see is that there are a couple of gossip_err()
calls in there that need to be updated so they don't use the "PVFS2
server:" prefix on the messages.
While you are messing with that stuff, would it be possible to add a
"starting" message to pvfs2-client-core (in the same format as
pvfs2-server) that prints on launch no matter what the gossip mask is?
It might also be good to print something on shutdown in a generic signal
handler as well. The segfault handler prints a message, but I don't
think anything is printed in the other cases.
-Phil
Sam Lang wrote:
I've attached two patches. The first tries to fix a basic bug where the
client-core doesn't cleanup if it receives SIGHUP unless --standalone is
provided. This means that event if the parent process forwards the
SIGHUP, the client-core process just exits (doesn't let operations
complete, and shutdown components). I've also added some handling for
cases where the client-core process is restarting too rapidly.
The second patch adds the backtrace debug printing info if the client
core process segfaults.
-sam
------------------------------------------------------------------------
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
