Sam - Yup, we're using it as part of the key database. I simply set the variable to initialize to zero for consistency. Do you see a problem with doing that?
- Dave > > Hi Dave, > > Good catch! It doesn't look like we actually use that function > anywhere, but I added it there in the hope that we would have a good > string hashing function to use instead of reinventing something ad-hoc > every time. Are you guys using it now for the security stuff? > > -sam > > On May 19, 2008, at 3:12 PM, David Bonnie wrote: > >> Everyone - >> >> I think I've found a bug in the string hashing function in >> /src/common/quickhash/quickhash.c. The function quickhash_string_hash >> uses an uninitialized variable (uint32_t h) as a starting point for >> the >> hash. This could lead to the hash function creating different >> hashes for >> the same key (and the compiler really doesn't like it). >> >> I've done a quick fix in our branch to make it consistent but it'd >> probably be a good idea for someone to check over it more thoroughly >> seeing as I'm no expert on hash functions. >> >> - Dave >> >> >> _______________________________________________ >> Pvfs2-developers mailing list >> [email protected] >> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers > > _______________________________________________ > Pvfs2-developers mailing list > [email protected] > http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers > _______________________________________________ Pvfs2-developers mailing list [email protected] http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
