Whoops, you are quite correct. I was not able to figure out why that patch was committed or why I took it, but it absolutely doesn't fix anything. When I saw the commit to head, I just assumed it was initialization changes; I will look a little closer next time. Thanks for catching that!
Bart. On Fri, May 6, 2011 at 11:58 AM, Becky Ligon <[email protected]> wrote: > Bart: > > These changes cause the credentials to be set to 0.0, which is root. So, > regardless of who you really are, the file gets created as root (or as > squashed root, if it is turned on). I don't think we want this change. > Seems more like these changes were put in the program just for testing. > > Becky > -- > Becky Ligon > HPC Admin Staff > PVFS/OrangeFS Developer > Clemson University > 864-650-4065 > > > It looks like this commit is missing from the OrangeFS release as well: > > > > > http://www.pvfs.org/fisheye/browse/PVFS/src/apps/admin/pvfs2-touch.c?r1=1.9&r2=1.10 > > > > Thanks for looking into these! > > Bart. > > > > > > > > On Tue, May 3, 2011 at 6:25 PM, Becky Ligon <[email protected]> wrote: > > > >> Thanks, Bart! > >> > >> I will take a look at them and test with OrangeFS before committing them > >> to our branch. > >> > >> Becky > >> -- > >> Becky Ligon > >> HPC Admin Staff > >> PVFS/OrangeFS Developer > >> Clemson University > >> 864-650-4065 > >> > >> > In April of last year there was a short exchange on this mailing list > >> > regarding some fixes to root squashing. I believe I provided one patch > >> and > >> > Phil or Sam provided another patch or two to fix some issues we were > >> > seeing. > >> > The emails indicated that the changes were committed, but the current > >> > OrangeFS release does not contain them. I attached two patches that > >> > contain > >> > the changes we took. I think they will apply cleanly to the current > >> > release > >> > if anyone wants to look at them again. > >> > > >> > Bart. > >> > _______________________________________________ > >> > Pvfs2-developers mailing list > >> > [email protected] > >> > http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers > >> > > >> > >> > >> > > > > >
_______________________________________________ Pvfs2-developers mailing list [email protected] http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
