When I build ROMIO with pvfs2 support, i get lots of warnings about
warning: variable 's_kmod_keyword_mask_map' is not needed and will not
be emitted. The attached patch making that structure 'const' appears to
make clang happier, and seems apropriate for this read-only data structure.
==robb
--
Rob Latham
Mathematics and Computer Science Division
Argonne National Lab, IL USA
Index: include/pvfs2-debug.h
===================================================================
--- include/pvfs2-debug.h (revision 10746)
+++ include/pvfs2-debug.h (working copy)
@@ -126,7 +126,7 @@
#define __DEBUG_ALL ((uint64_t) -1)
/* map all config keywords to pvfs2 debug masks here */
-static __keyword_mask_t s_keyword_mask_map[] =
+static const __keyword_mask_t s_keyword_mask_map[] =
{
/* Log trove debugging info. Same as 'trove'.*/
{ "storage", GOSSIP_TROVE_DEBUG },
Index: src/common/misc/pvfs2-debug.c
===================================================================
--- src/common/misc/pvfs2-debug.c (revision 10746)
+++ src/common/misc/pvfs2-debug.c (working copy)
@@ -12,7 +12,7 @@
#include "pvfs2-internal.h"
#include "pvfs2-debug.h"
-static uint64_t debug_to_mask(__keyword_mask_t *mask_map,
+static uint64_t debug_to_mask(const __keyword_mask_t *mask_map,
int num_mask_map, const char *event_logging)
{
uint64_t mask = 0;
_______________________________________________
Pvfs2-developers mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
