[EMAIL PROTECTED] wrote on Tue, 11 Mar 2008 22:44 -0400:
> I've done a bit of patching to the 2.7.0 build system and am hoping that
> some of the ideas expressed might be useful or even good enough to be
> included in the source.
>
> I apologize that the first one lumps so much together, but it was either that
> or submitting patches that depended on each other. Hopefully I chose the
> least annoying method.
I'll take the first stab at a response. There's a lot here that we
might thread off the discussion some. Thanks for all the fine
patches!
Unfortunately some of this work may collide with other changes that
went into CVS after 2.7.0.
> 2.7.0-ac_vars-threaded_libs-so_name.patch:
> - Fixes the use of variables inherited from autotools so that DESTDIR
> behaves in the normal fashion. Also allows the user to define a few
> more paths and grabs some other nice path-related variables from
> autotools.
> - Adds version, minor and revision numbers to shared libraries.
There's a bit much in here to think about clearly. I believe that
the DESTDIR and shlib version numbers would be good bits; would you
be willing to pull them out separately? And based on CVS rather
than 2.7.0 would make it a lot easier for us to deal with.
> - Enables the building of threaded libraries with --enable-threaded-libs.
I had a go at that area, sort of, post-2.7.0:
http://www.pvfs.org/fisheye/changelog/PVFS?cs=MAIN:pw:20080215191720
And maybe you are doing something different. Do you need a knob to
control whether the threaded client libs get built? The new default is
that they don't, unless you go out of your way to ask for
--enable-threaded-kmod-helper. Do you have a reason to want to turn
them on?
> - Allows the building of just the kernel module, without the dependency
> on kernapps.
I thought that was what just_kmod did. Maybe you want something else?
> 2.7.0-configure-static-server.patch:
> - Fixes the use of AC_ARG_ENABLE so that --disable-static-server actually
> does disable the static server and build the shared one by default.
Looks obviously good; applied, thanks.
> 2.7.0-as-needed.patch:
> - Just fixes a couple of places where using -Wl,--as-needed will break
> the build.
I don't understand. Do we need -lcrypto instead of -lcrypt, or
both? For the LDFLAGS part, I've just checked in a fix; thanks for
that for sure.
> 2.7.0-Wno-strict-aliasing-2-.patch
> - This one is strange and I'm not sure about it, but there were reports
> that this flag was actually causing warnings to be printed, instead of
> ignoring them, hence breaking builds. See:
> http://bugs.gentoo.org/show_bug.cgi?id=210923
Just yesterday or so I may have fixed this one a different way:
http://www.pvfs.org/fisheye/changelog/PVFS/?cs=MAIN:pw:20080311153354
Maybe there is some other need for changing the no-strict-alias
arg, but I think what's in CVS should address the bug report.
-- Pete
_______________________________________________
Pvfs2-users mailing list
[email protected]
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-users
