> could you please write a couple of tests for this? It's very hard to see > what this code is doing and whether it is broken without tests for its > functionality.
It is just allowing for less than 4 arguments in __import__. Maybe there is a more elegant/bvious way? The existing code always uses the 4 argument version, and it works, no import would work if that goes wrong. I have one use case (not yet checked in) that works with this change. So I see no need to add more direct tests. Nothing would work if this is wrong. Just a corner case where the annotator is too restrictive. (of course I could have used 4 arguments, but it's not nice) cheers - chris -- Christian Tismer :^) <mailto:[EMAIL PROTECTED]> tismerysoft GmbH : Have a break! Take a ride on Python's Johannes-Niemeyer-Weg 9A : *Starship* http://starship.python.net/ 14109 Berlin : PGP key -> http://wwwkeys.pgp.net/ work +49 30 802 86 56 mobile +49 173 24 18 776 fax +49 30 80 90 57 05 PGP 0x57F3BF04 9064 F4E1 D754 C2FF 1619 305B C09C 5A3B 57F3 BF04 whom do you want to sponsor today? http://www.stackless.com/ _______________________________________________ [EMAIL PROTECTED] http://codespeak.net/mailman/listinfo/pypy-dev
