holger krekel wrote:
> Transparently inheriting AUTH info might sometimes not be desired
> or be tricky, not sure.  I'd try this after all else is done (see below). 
>
>   
Not sure about this one. If you do a checkout with authentication args, 
all children will be checked out with the same credentials. If you later 
perform an action on that child that requires authentication, I think 
the expected behaviour is that the credentials used for the previous 
checkout are used, unless other credentials are provided.

>> * Many new arguments required
>>
>>   I think it's not very nice to have so many new arguments to the 
>> constructors,
>>   and especially dislike having an argument that's only useful when other 
>> args
>>   are provided (auth_cache). Not sure how to improve that, though...
>>     
>
> What about a py.path.SvnAuth class ... 
>
>   
I was thinking about something like that, but figured it would be kind 
of heavy for just the SVN auth... However,

> Eventually we might want to generalize SvnAuth slightly 
> into some Identity or Auth class that can also be 
> used e.g. for py.execnet.SshGateway.  
>
>   
in that case it may be nice to have, indeed... ;)

Then...

 > * then add an explicit 'svnauth' parameter to wc.checkout and wc.commit

>  (which other svnwc methods need it?) 

Well, that depends on the use case. For a repository that requires 
authentication for all types of access, if the path objects aren't created with 
credentials passed to the constructor, it may be needed for all actions that 
hit the server (e.g. update, lock, etc.).

Perhaps it makes more sense to only allow passing auth to the constructor? I 
don't really see a use case for using different credentials for different 
methods, but I may overlook something?

Cheers,

Guido

_______________________________________________
py-dev mailing list
py-dev@codespeak.net
http://codespeak.net/mailman/listinfo/py-dev

Reply via email to