Doesn't the patch now always return registered - also invalid according to the JEP?
On 1/13/06, Arnaud Ab?lard <[EMAIL PROTECTED]> wrote: > Gonzalo Barrio a ?crit : > > I made a patch for the second bug, is in sourceforge page. > > Indeed, i found it, thanks! > > While i was there, I added a patch to fix the first bug project's > sourceforge bug page. > > Arnaud > > > > > > Cheers, > > > > Gonzalo Barrio Linares. > > > > > > Arnaud Ab?lard wrote: > > > >> hello, > >> > >> I've been working on the xmpppy based yahoo transport and i've found > >> several bugs: > >> > >> - in the registration code: when a client does a jabber:iq:register > >> query, the transport doesn't return <registered><registered/> when the > >> user is registered with the transport. Therefore some clients (like > >> pandion) won't let the user unregister from the transport. > >> This breaks JEP-77: > >> > >> > >> From: http://www.jabber.org/jeps/jep-0077.html#schemas-register > >> > >> "If the host determines (based on the 'from' address) that the entity > >> is already registered, the IQ result that it sends in response to the > >> IQ get MUST contain an empty <registered/> element (indicating that > >> the entity is already registered), SHOULD contain the registration > >> information currently on file for the entity (although the <password/> > >> element MAY be empty), and SHOULD contain an <instructions/> element > >> (whose XML character data MAY be modified to reflect the fact that the > >> entity is currently registered)." > >> > >> > >> > >> - still in the registration handle code: it looks like that after > >> getting the iq jabber:iq:register set query, the transport never sends > >> the iq jabber:client result packet: > >> > >> SENT: <iq type="get" id="sd110" > >> to="yahoo-test.jabber.univ-nantes.fr"><query > >> xmlns="jabber:iq:register" xml:lang="fr"/></iq> > >> RECV: <iq xmlns="jabber:client" > >> to="[EMAIL PROTECTED]/Pandion" > >> from="yahoo-test.jabber.univ-nantes.fr" id="sd110" > >> type="result"><query xmlns="jabber:iq:register"><instructions>Please > >> provide your Yahoo! username and > >> password</instructions><username></username><password></password></query></iq> > >> > >> RECV: <iq xmlns="jabber:client" > >> to="[EMAIL PROTECTED]/Pandion" > >> from="yahoo-test.jabber.univ-nantes.fr" id="73" type="get"><query > >> xmlns="http://jabber.org/protocol/disco#info";></query></iq> > >> SENT: <iq type="result" to="yahoo-test.jabber.univ-nantes.fr" > >> id="73"><query xmlns="http://jabber.org/protocol/disco#info";><identity > >> category="client" type="pc"/><feature > >> var="http://jabber.org/protocol/disco#info"/><feature > >> var="http://jabber.org/protocol/muc"/><feature > >> var="http://jabber.org/protocol/xhtml-im"/><feature > >> var="jabber:iq:avatar"/><feature var="jabber:iq:last"/><feature > >> var="jabber:iq:oob"/><feature var="jabber:iq:time"/><feature > >> var="jabber:iq:version"/></query></iq> > >> SENT: <iq type="set" id="sd111" > >> to="yahoo-test.jabber.univ-nantes.fr"><query > >> xmlns="jabber:iq:register" > >> xml:lang="fr"><username>arnytest</username><password>mypassword</password><nick>ArnYTesT</nick><key></key></query></iq> > >> > >> > >> <!-- here is missing the result packet from the transport! --> > >> > >> RECV: <presence xmlns="jabber:client" > >> to="[EMAIL PROTECTED]/Pandion" > >> from="yahoo-test.jabber.univ-nantes.fr" id="74" type="set"></presence> > >> RECV: <presence xmlns="jabber:client" > >> to="[EMAIL PROTECTED]/Pandion" > >> from="yahoo-test.jabber.univ-nantes.fr" id="78"></presence> > >> RECV: <presence xmlns="jabber:client" > >> to="[EMAIL PROTECTED]/Pandion" > >> from="yahoo-test.jabber.univ-nantes.fr" id="79"></presence> > >> > >> Arnaud > >> > >> _______________________________________________ > >> py-transports mailing list > >> py-transports@blathersource.org > >> http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports > >> > > > > > > _______________________________________________ > > py-transports mailing list > > py-transports@blathersource.org > > http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports > > _______________________________________________ > py-transports mailing list > py-transports@blathersource.org > http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports > -- - Norman Rasmussen - Email: [EMAIL PROTECTED] - Home page: http://norman.rasmussen.co.za/ From [EMAIL PROTECTED] Fri Jan 13 09:43:50 2006 From: [EMAIL PROTECTED] (Norman Rasmussen) Date: Fri Jan 13 09:43:58 2006 Subject: [py-transports] MSN Wierdness In-Reply-To: <[EMAIL PROTECTED]> References: <[EMAIL PROTECTED]> Message-ID: <[EMAIL PROTECTED]> It's been a while since I've added someone to my list (a few weeks), but I remember seeing the same issue last time I did. Eventually (after the MSN servers have dropped you a few times) it works. On 1/13/06, Eric Langheinrich <[EMAIL PROTECTED]> wrote: > I'm running into some problems with adding MSN buddies using the PyMSNt > transport. > > When I am signed onto MSN through the transport and someone adds me to their > buddy list, I never show online. If I log out of jabber and the transport > and sign into MSN they are able to see me. If I log back into the transport > they are still able to see me at that point. > > With just a couple of quick tests, it appears the same behavior happens the > other direction. Where if I am signed in through the transport and add a > buddy, I never see that buddy come online. But if I add them through MSN, I > can see them. > > Any ideas? > > _______________________________________________ > py-transports mailing list > py-transports@blathersource.org > http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports > -- - Norman Rasmussen - Email: [EMAIL PROTECTED] - Home page: http://norman.rasmussen.co.za/ From [EMAIL PROTECTED] Fri Jan 13 17:39:51 2006 From: [EMAIL PROTECTED] (=?ISO-8859-1?Q?Arnaud_Ab=E9lard?=) Date: Fri Jan 13 17:39:59 2006 Subject: [py-transports] yahoo-transport registration bugs In-Reply-To: <[EMAIL PROTECTED]> References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> Message-ID: <[EMAIL PROTECTED]> Norman Rasmussen a ?crit : > Doesn't the patch now always return registered - also invalid > according to the JEP? gasp!! first, i mess the patch, and then the patch is worst than the bug itself 8-/ Of course registered needs to be sent only if userfile.has_key(fromjid) is true. I'll update the bug report on sf :/ Arnaud > > On 1/13/06, Arnaud Ab?lard <[EMAIL PROTECTED]> wrote: > >>Gonzalo Barrio a ?crit : >> >>>I made a patch for the second bug, is in sourceforge page. >> >>Indeed, i found it, thanks! >> >>While i was there, I added a patch to fix the first bug project's >>sourceforge bug page. >> >>Arnaud >> >> >> >>>Cheers, >>> >>>Gonzalo Barrio Linares. >>> >>> >>>Arnaud Ab?lard wrote: >>> >>> >>>>hello, >>>> >>>>I've been working on the xmpppy based yahoo transport and i've found >>>>several bugs: >>>> >>>>- in the registration code: when a client does a jabber:iq:register >>>>query, the transport doesn't return <registered><registered/> when the >>>>user is registered with the transport. Therefore some clients (like >>>>pandion) won't let the user unregister from the transport. >>>>This breaks JEP-77: >>>> >>>> >>>>From: http://www.jabber.org/jeps/jep-0077.html#schemas-register >>>> >>>>"If the host determines (based on the 'from' address) that the entity >>>>is already registered, the IQ result that it sends in response to the >>>>IQ get MUST contain an empty <registered/> element (indicating that >>>>the entity is already registered), SHOULD contain the registration >>>>information currently on file for the entity (although the <password/> >>>>element MAY be empty), and SHOULD contain an <instructions/> element >>>>(whose XML character data MAY be modified to reflect the fact that the >>>>entity is currently registered)." >>>> >>>> >>>> >>>>- still in the registration handle code: it looks like that after >>>>getting the iq jabber:iq:register set query, the transport never sends >>>>the iq jabber:client result packet: >>>> >>>>SENT: <iq type="get" id="sd110" >>>>to="yahoo-test.jabber.univ-nantes.fr"><query >>>>xmlns="jabber:iq:register" xml:lang="fr"/></iq> >>>>RECV: <iq xmlns="jabber:client" >>>>to="[EMAIL PROTECTED]/Pandion" >>>>from="yahoo-test.jabber.univ-nantes.fr" id="sd110" >>>>type="result"><query xmlns="jabber:iq:register"><instructions>Please >>>>provide your Yahoo! username and >>>>password</instructions><username></username><password></password></query></iq> >>>> >>>>RECV: <iq xmlns="jabber:client" >>>>to="[EMAIL PROTECTED]/Pandion" >>>>from="yahoo-test.jabber.univ-nantes.fr" id="73" type="get"><query >>>>xmlns="http://jabber.org/protocol/disco#info";></query></iq> >>>>SENT: <iq type="result" to="yahoo-test.jabber.univ-nantes.fr" >>>>id="73"><query xmlns="http://jabber.org/protocol/disco#info";><identity >>>>category="client" type="pc"/><feature >>>>var="http://jabber.org/protocol/disco#info"/><feature >>>>var="http://jabber.org/protocol/muc"/><feature >>>>var="http://jabber.org/protocol/xhtml-im"/><feature >>>>var="jabber:iq:avatar"/><feature var="jabber:iq:last"/><feature >>>>var="jabber:iq:oob"/><feature var="jabber:iq:time"/><feature >>>>var="jabber:iq:version"/></query></iq> >>>>SENT: <iq type="set" id="sd111" >>>>to="yahoo-test.jabber.univ-nantes.fr"><query >>>>xmlns="jabber:iq:register" >>>>xml:lang="fr"><username>arnytest</username><password>mypassword</password><nick>ArnYTesT</nick><key></key></query></iq> >>>> >>>> >>>><!-- here is missing the result packet from the transport! --> >>>> >>>>RECV: <presence xmlns="jabber:client" >>>>to="[EMAIL PROTECTED]/Pandion" >>>>from="yahoo-test.jabber.univ-nantes.fr" id="74" type="set"></presence> >>>>RECV: <presence xmlns="jabber:client" >>>>to="[EMAIL PROTECTED]/Pandion" >>>>from="yahoo-test.jabber.univ-nantes.fr" id="78"></presence> >>>>RECV: <presence xmlns="jabber:client" >>>>to="[EMAIL PROTECTED]/Pandion" >>>>from="yahoo-test.jabber.univ-nantes.fr" id="79"></presence> >>>> >>>>Arnaud >>>> >>>>_______________________________________________ >>>>py-transports mailing list >>>>py-transports@blathersource.org >>>>http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports >>>> >>> >>> >>>_______________________________________________ >>>py-transports mailing list >>>py-transports@blathersource.org >>>http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports >> >>_______________________________________________ >>py-transports mailing list >>py-transports@blathersource.org >>http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports >> > > > > -- > - Norman Rasmussen > - Email: [EMAIL PROTECTED] > - Home page: http://norman.rasmussen.co.za/ > _______________________________________________ > py-transports mailing list > py-transports@blathersource.org > http://www.modevia.com/cgi-bin/mailman/listinfo/py-transports
