On 17/01/2007, at 5:14 PM, Weng Wei wrote: > hi, everyone~ > > I am a Chinese programmer new to python. In fact, I come to know > python & twisted because of Pymsnt. > > Currently, I am playing pymsnt-0.11.2. During my testing, it seems > that I found the following two issue: > > 1. SYN command for new msn account ( msn account that has no > contatct at all > > In msn.py, handle_SYN method, line 1242: > if params[3] == 0: # No LST will be received. New > account? > > Should be: if params[3] == '0': > > And seem should not set the State to "Session" immediately, > otherwise the subsequent SVN respponse won't be handle correctly. > However, as there are no "LST" response for new account, if we > don't set the State to 'Session' here, where should we set it? > > 2. Connectors of SwitchboardSessionBase > > I notice that in msnw.py, the SwitchboardSessionBase class just > make connection to Switchboard (line 505, 520) without keeping the > connectors. > > Isn't it better to keep these connectors and disconnect them > actively when signing out? Just like the MSNConnection class. > > It seems that even after a client Signout from msn, the Switchboard > server won't disconnect these sessions immediately. Normally they > are disconnected after 5 mins or never. This seems would result in > some kind of "memory leak". > > Any advise? > > Thanks a lot~
Thanks. I've fixed both of these issues now. --- James _______________________________________________ py-transports mailing list py-transports@blathersource.org http://lists.modevia.com/cgi-bin/mailman/listinfo/py-transports
