Woo hoo! I saw the staggering number of commits and figured it would be stuck in code review for a month. Very cool to see them merged in quickly. Looking forward to helping out in any way.
On Thu, Aug 2, 2018 at 8:26 AM, René Dudfield <ren...@gmail.com> wrote: > Thanks you two :) That's very kind. > > Currently I merged Lenard's epic SDL2_patches branch into master. Sdl1 is > still the default, and it's testing ok on win, Linux, mac build bots. > > Only Linux compiles with sdl2 so far, but I'm working on mac today - and > will update the compilation notes on the wiki as I go. There's some > comments in the PR, pointing out parts that still need compatibility code > written. These will eventually make it into the '2' milestone 'Are we > pygame 2 yet?' > > Cleaning up the build system and getting sdl2 binary builds onto pypi will > take some time I expect. > > This is some seriously monster-fucking-epic work by Lenard who first > started on the patches in 2013 I believe!!! > > > cheerio, > > > > On Wednesday, August 1, 2018, Chris Handy <maximi...@gmail.com> wrote: > >> My daytime job is writing cross-platform code in Python; I'm happy to >> help out with either Windows, Linux or Mac builds. >> >> On 1 August 2018 at 04:54, Luke Paireepinart <rabidpoob...@gmail.com> >> wrote: >> >>> Sounds reasonable to major version up with SDL. Is there a sponsor on >>> the list for the windows builds of pygame? If not, I would love to >>> volunteer for this. >>> >>> >>> On Tue, Jul 31, 2018, 7:29 AM René Dudfield <ren...@gmail.com> wrote: >>> >>>> So. I've been thinking how to have SDL2 and SDL1 releases on pypi at >>>> the same time. >>>> >>>> 1.9.5.devX releases, with SDL1 being compiled in. >>>> 2.0.0.devX releases, using SDL2 stuff. >>>> >>>> The benefit is that we can: >>>> >>>> - 'release early, release often'. The fact is most people only >>>> test, or try things out once things are released. >>>> - we need help testing a SDL2 pygame, and having it on pypi makes >>>> that easy for people. My guess is only 2-3 people have tried the SDL2 >>>> branch so far for example. >>>> - there's only one tree, which is easier to maintain than separate >>>> branches. >>>> - we also need help testing SDL1 stuff, to make sure it hasn't >>>> broken. >>>> >>>> >>>> >>>> *Step 1.* >>>> The first step is to get the continuous releases working, and I'll >>>> reset the version number in git master to 1.9.5.dev0 >>>> Each merge into master will do a release to pypi as 1.9.5.devX, where X >>>> is the number of commits since the last release tag (1.9.4). >>>> >>>> >>>> *Step 2.* >>>> Unfortunately I don't see a way to merge the SDL2 branch in >>>> incrementally. >>>> So I'll do a big merge of the SDL2 stuff into master. >>>> With SDL1 being the default. >>>> >>>> *Step 3.* >>>> Do the repo files cleanup (mentioned earlier). >>>> >>>> >>>> *Step 4.* >>>> Get pygame 2 working on non-linux platforms. >>>> Get continuous deploys working for pygame 2.0.0.devX. >>>> >>>> *Step 5.* >>>> There will be a pygame 1.9.5 release with the API cleanup, and disabled >>>> SDL2 support. >>>> Including other platform fixes (like how *BSD pygame is broken >>>> currently). >>>> >>>> >>>> So, that's the plan. >>>> >>> >>