> Thanks, I've fixed the documentation in r1442 (there's no good reason
> for the current implementation, but neither is there a good reason to
> change it at this stage).
>
I'll buy you a beer if you fix it. I mean ... the patch is dirt simple (see
attached).
I guess it's a matter of correctness - testing if the return value isn't
None doesn't have the better semantics of zero/nonzero checking. If it did,
the one could do the following (which should be valid):
...
return symbol != key.ESCAPE
OR
...
return symbol not in global_keys
--
\\\\\/\"/\\\\\\\\\\\
\\\\/ // //\/\\\\\\\
\\\/ \\// /\ \/\\\\
\\/ /\/ / /\/ /\ \\\
\/ / /\/ /\ /\\\ \\
/ /\\\ /\\\ \\\\\/\
\/\\\\\/\\\\\/\\\\\\
d.p.s
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"pyglet-users" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/pyglet-users?hl=en
-~----------~----~----~----~------~----~------~--~---
Index: pyglet/event.py
===================================================================
--- pyglet/event.py (revision 1444)
+++ pyglet/event.py (working copy)
@@ -265,7 +265,7 @@
handler = frame.get(event_type, None)
if handler:
ret = handler(*args)
- if ret != EVENT_UNHANDLED:
+ if ret:
return
# Check instance for an event handler
