On Thu, Apr 29, 2010 at 2:49 PM, Joe Wreschnig <[email protected]> wrote: > On Thu, Apr 29, 2010 at 11:45 AM, Bruce Smith <[email protected]> wrote: >> On Thu, Apr 29, 2010 at 9:48 AM, Joe Wreschnig <[email protected]> >> wrote: >> As for the specific issues: >> >> 480 -- I think the "3x speedup" should be mentioned in the issue itself, and >> also you should make clear if this is just measured in the specific function >> (as your timeit example suggests), or in the speed of some realistic whole >> example which uses this function. The issue also claims the current code is >> "too slow" without providing any evidence for that. ("Slower than it could >> be" does not imply "too slow".) > > Maybe you should stick to the areas of your expertise. Any profiling > of a game with lots of moving sprites will show invalidate near the > top, as the invalidation happens whenever you rebuild the vertex list, > which happens when you change any property.
In keeping with the flippant character of this conversation, I should point out that the creators of pyglet consider the Sprite class to basically be a toy for beginners, and that serious games developed with Pyglet will generally not use it. I can't say that I personally agree with this general philosophy, but I thought I would point it out. [..] > I sure hope the documentation is still generated from epydoc, because > I added the stupid-looking annotations for it. > > Maybe this is a difference of expectations. I expect whoever commits > my patches to eventually read the code, not the stuff in the issue > tracker. The stuff in the issue tracker is there to help searches, let > people comment, and link/attach updated patches. It is not a place to > repeat everything I did in the code. You seem to expect to never need > to even glance at the code of the patches you are vetting. If that's > the case, I might as well just be given committer privileges. Richard is the only person in this conversation thus far that has the ability to grant committer privs. I don't think you've insulted him yet, so that's good. -Casey -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyglet-users?hl=en.
