I don't usually get involved with these implementation debates primarily because I don't ever contribute code.

In this case however, I reckon the imports need to pass flake8.

Also, I reckon even I could submit a couple of pull requests to fix this stuff.

Take care all,


On 27 September 2017 07:59:38 Marcus Ottosson <[email protected]> wrote:



Hi all,

As a follow up to my previous gory thread on six versus future
<https://groups.google.com/forum/#!topic/pyglet-users/RabT8mUFqRA>, I’d now
like to draw your attention to another aspect of the pyglet that caught my
eye.

135 matches across 85 files

I’m talking of course about the use of from x import *. Moving forward,
what are your thoughts these? To me, they complicate life for my fellow
linter (Sublime), make it a little tougher to understand from which module
a particular implementation is coming from and complicate the refactoring
process when taking away my ability to search/replace.

What are your thoughts on swapping these for an explicit import, e.g. from
pyglet import gl; gl.texGend? I did search for a previous discussion on
this but came up empty, both here and on BitBucket. I figure there has
probably been a discussion about it in some form, but thought it might be
helpful to have one openly and for future newcomers wondering about the
same thing. It’s a little unexpected, a little un-pythonic.
​

--
You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/pyglet-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups 
"pyglet-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/pyglet-users.
For more options, visit https://groups.google.com/d/optout.

Reply via email to