This is great feedback, and a perfect time to discuss. Dan, I like that idea, because the API is simple and clean. One issue, could be if the user wants to do the following: 1. User creates a list of 10 songs, and then queues them. 2. The User wants these 10 songs to get repeated as a group, not individually. (Like a music playlist, on repeat).
This is one use case that I didn't think of before, and it seems that the SourceGroup was used for. I suppose an alternative, would be to allow passing an iterable to `Player.queue`. That list of sources could be treated as a group. If loop=True is also passed, they could be looped as a group as well. I guess the question is whether it makes sense to put all of this code inside the Player class or not? On Friday, November 24, 2017 at 8:29:43 PM UTC+9, Alice Haugen wrote: > > Thanks for the work on this! > > One issue I encountered: one of my libraries wants to play an audio file, > then loop from a certain point rather than the beginning of the audio. > Previously, it was tolerably effective to divide the audio into "intro" and > "looping" files, create a SourceGroup for the "looping" file with loop set, > and then queue the intro file and the SourceGroup. With the change of > SourceGroup into PlayList and migration of loop to the Player, this no > longer appears possible. I can handle this by e.g. setting loop on the > Player from on_player_next_source, but this is less elegant and more > prone to error than the earlier solution. > -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
