On Mon, 16 Feb 2009 22:03:39 -0800
"C. Titus Brown" <[email protected]> wrote:

> Right now all of the test scripts and the test utilities are in one
> directory.  What do you think of making a 'testlib' package, or a
> subdirectory that contains all of the test utilities?
That would indeed be a good idea.

> The temp directory should probably be nuked each time the tests are
> run. The second time I ran the tests I got a prompt complaining that
> a file already existed & did I want to overwrite it?
Myself I would go even further and have each test create its
own, randomly-named, temporary directory, just to be safe. Moreover,
I'd recommend using the tempfile module for that purpose rather than
handling the matter using custom code.

> These should all be fixed.  I'm happy to do that on my second code
> review as long as everyone is OK with it.
Fine by me! Good work.

-- 
MS

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"pygr-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to