On Mar 3, 2009, at 12:27 PM, Istvan Albert wrote:
>> > all test now pass, Chris is porting the sqlite tests. I restored Titus version of sqltable_test.py to get back all my sqlite tests, then revamped it somewhat to clean up the code. I also re- added the SQLiteGraph_Test to be included in the automated tests. At this point we have 190 tests; all pass on my Mac. Get the latest code from git://github.com/cjlee112/pygr.git, branch psu-tests-branch. Istvan, can you make sure that the sqlite tests pass on Windows? I am deleting the sqlite file at the end of the test, after carefully closing both the sqlite cursor and connection. I know Windows will raise an exception if you try to delete a file that you still have open... I think now or very shortly we can merge all this into the master branch. We just need to make sure we are all happy with all the changes, especially any changes in the core pygr modules -- there are a few such changes. For example, Istvan made some changes for MySQL config file finding on Windows. -- Chris > > > TempDir is in an odd state, it is still not helpful enough if you were > trying to find some files. It needs to generate useful filenames. For > example files generated by nlmsa tests should go into the folders > names nlmsa-foo etc. > > We talked with Chris and got to favor an option where > you can set a command line option for a path to where all test related > folders would go (Titus has proposed something along that lines too). > > Right now this directory by default points to tests/tempdir but you > can point it anywhere else. I think all three of us should briefly discuss this. The basic elements that have emerged from our efforts so far seem to be: - all test "temporary" files for a given run should go under a single test root location (possibly in subdirectories) that can be controlled at the top-level. - Istvan wants to leave temp files in existence after the tests finish, to make it easy to debug test failures - before the tests start, if the test root location already is an existing directory, Istvan proposes to wipe it out to ensure that nothing from previous tests can affect it. - simultaneous test runs could avoid interference by creating a time stamp in the test root location when they start, and deleting it when they exit. If a new test run sees that time stamp in existence, another test must be running and it should use a different test root location (e.g. by exiting with a message that tells the user to pass it a new test root location). - we still need to worry about the possibility that test files generated early in the test suite could affect later tests in the same run of the test suite. Strictly speaking, the only way to guarantee that no such side effects are possible is to delete them at the end of each test in the suite or isolate every single test to a different directory. Which is better? -- Chris --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
