On Mar 20, 2009, at 8:06 PM, Istvan Albert wrote:
> Some of Chris' code uses a convention that adds the comment at the end > of the line, thus makes lines too long. I think the comments should go > above and do not need to be all caps either. That will make the code > examples fit in nicely. I used to write comments in all-caps due to an old habit leftover from the days before good code highlighting was ubiquitous; it's totally unnecessary now, and I abandoned the practice a couple years ago. I have been replacing the all-caps comments in any code that I change or add. As part of 0.8, I suggest we just replace the remaining all-caps comments with lowercase. I now keep my buffer 80 characters wide, and split any lines that are longer than that. Again as part of 0.8 we could try to split any remaining lines that are longer than 80 characters. Titus, regarding PEP 8, I have to confess I had forgotten that it calls for a blank line after every method. Especially for methods that are only a few lines, I tended not to do that, because I thought the indentation showed the method boundaries clearly, and I like to be able to see as much of a class "at a glance" (i.e. in a window) as possible, to see how all the methods work together. But we can add the extra blank lines if people feel this improves readability. -- Chris --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to pygr-dev@googlegroups.com To unsubscribe from this group, send email to pygr-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---