On Fri, Apr 17, 2009 at 09:58:44PM -0700, Christopher Lee wrote: -> On Apr 17, 2009, at 1:05 PM, Istvan Albert wrote: -> -> > -> > - installing cygwin and compiling pygr within cygwin as if it were -> > unix, no changes should be necessary. It should compile fine although -> > I remember once having trouble with bsdb not being installed properly -> -> I installed cygwin and built Pygr using it without any problems. I -> hit two problems in the test suite: -> -> - seqdb_test.SequenceFileDB_Creation_Test hangs because Titus' test -> deletes the shelve file from the filesystem using os.unlink() without -> first making that the shelve is closed. On windows this leads to -> mayhem; trying to open the shelve later hangs. This is a problem with -> the testing framework, rather than Pygr itself. But it does highlight -> the importance of ensuring that shelve files get closed properly. -> Currently we rely on shelve's default behavior (i.e. when the shelve -> object is garbage collected, it closes itself). That doesn't seem -> wrong, but it creates a risk that users may try to do things like -> delete the seqlen file without having first closed the sequence file db? -> -> The only idea that comes to mind is to make explicitly closing a -> sequence database object a requirement of the SequenceDB API? i.e. -> you must execute db.close() when you are done with the database. Does -> that seem like a good requirement to add?
Yes; I thought about suggesting it during my review but couldn't think of a functional reason for doing so; it just seemed neat. Now we have a reason, though ;) (Providing the function is sufficient; I don't think we need to require that it be called in most circumstances.) --titus -- C. Titus Brown, c...@msu.edu --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to pygr-dev@googlegroups.com To unsubscribe from this group, send email to pygr-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
