On Fri, Apr 24, 2009 at 02:53:12PM -0700, Marek Szuba wrote:
-> It seems I've finally figured out the problem pygrdata_test had...
-> Arguments passed to os.system weren't quoted, causing problems whenever
-> paths contained spaces (*groan*).
->
-> I've posted the patch to the "ossystem_quote" branch on Github,
-> applying it to the "must_close" branch makes pygrdata_test pass on
-> Win32.
hey Marek,
first, there's something messed up with git on one of your systems
(presumably a Windows system?): your commit Author line is wrong,
Author: unknown <p...@.(none)>
for patch 55f1ec5f4c999ef91e896eaa9b2c7f0ac8f70be3.
second, I think we should use commands.mkarg for this. (Little known
not-really-public API that took me a while to track down ;). We can
transplant it from the Python tree if necessary; it's a tiny function.
It's gone in py3k, but that's ok -- subprocess is there.
See http://github.com/ctb/pygr/tree/ossystem_quote_mkarg
and
http://github.com/ctb/pygr/commit/f5f91ef74e116055935fd656c9ccea3ba802883c
cheers,
--titus
--
C. Titus Brown, c...@msu.edu
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"pygr-dev" group.
To post to this group, send email to pygr-dev@googlegroups.com
To unsubscribe from this group, send email to
pygr-dev+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
