On Apr 27, 2009, at 9:05 PM, C. Titus Brown wrote:

> Huh.  I thought I'd tested it on python2.3... very annoying.  On my  
> 2.3
> install, I sometimes see that the XML-RPC server is running on one  
> port
> but the connection attempt is to another port.  Perhaps in 2.3 ports
> aren't relinquished so easily and so you get clashes if you use a  
> single
> port??  Dunno why this would show up now!  Ahh, the test running order
> may have changed slightly.  Interesting.
>
> Merging in the xmlrpc_random_port branch actually fixes this problem,
> implying that port release is, indeed, the issue.  Hmm.

Great.  If no one has any objection, I'd like to merge  
xmlrpc_random_port + runtest_single + popen_tmp and push all of that  
to master, as this would get us (back) to all tests passing on all  
platforms (now including Windows, and Python 2.3).

RE: popen_tmp, it provides fairly minor bug fixes that you and Istvan  
recommended:

- use subprocess / mkarg for marshaling arguments to run the XMLRPC  
server test.  That is exactly what our standard mechanism FilePopen  
provides.

- fixed Istvan's point that commands.mkarg (which FilePopen used on  
Python 2.3) will not work on Windows.

- fixed FilePopen to support PIPE=stderr on Python 2.3, by supporting  
stderr redirection on both sh and csh environments.

- changed a couple usages of FilePopen in blast.py to explicitly close  
the open files (rather than relying on garbage collection to take care  
of that), just as we decided to do for seqdb.  This is mainly  
important for avoiding possible wierd situations on Windows where  
someone deletes a file that is still open...

-- Chris
>
>
> The sqltable_test having a get_suite is an oversight.  We should axe  
> it.
>
> See testlib/unittest_extensions.py, method addError, for the skip
> functionality.

I'll take a look.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"pygr-dev" group.
To post to this group, send email to pygr-dev@googlegroups.com
To unsubscribe from this group, send email to 
pygr-dev+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to