On May 25, 2009, at 8:06 PM, C. Titus Brown wrote:
> Sixth, I forgot to update my pygr version (I was working in an old > branch, sigh) and ran across the multirecord blast parsing bug that > Chris fixed a bit ago. Was a test case entered for this? > > http://github.com/cjlee112/pygr/commit/001a66af4c658649f1570f953b5ad61923e43414 > > It doesn't seem like it. I'm worried about changes like that, and > this, > > http://github.com/cjlee112/pygr/commit/f26f444309b0af932e4937714b5b23e8865f072d > > both of which fix bugs that should have been caught by our test > framework, but weren't; then, when they were fixed, no test was > entered. I'm sympathetic to the need to maintain momentum but Here Be > Dragons... this is a bad way to move forward IMO. Hi Titus, Marek had development ongoing on new blast tests when I fixed this bug, so I asked him to add the test case to his branch. If I added it myself, our changes to the blast_test.py test code would clash and could not be merged cleanly by git. The bug fix was made on the master branch, but Marek's experimental branch is still ongoing. When he tells me it's ready to push, I'll do so right away. Thanks for being vigilant!! -- Chris --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to pygr-dev@googlegroups.com To unsubscribe from this group, send email to pygr-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
