On Tue, May 26, 2009 at 11:41:48AM -0700, Christopher Lee wrote: -> On May 26, 2009, at 11:35 AM, C. Titus Brown wrote: -> -> > I tend to feel that examples speak louder than 1000 words, so maybe -> > I'll -> > try doing some refactoring and send it your way, more as an example -> > than -> > as a submission. -> -> Perfect. That is the other option I was going to suggest, but -> hesitated to do so since it's even more work for you...
Well, I'm glad I spent some time on it -- I misunderstood how widely read_alignment_coords and add_aligned_intervals were being used! So, I spent some time putting in whitespace & comments, and pulling apart the code. On the branch 'ctb_intervals', you can see all the work: http://github.com/ctb/pygr/commits/ctb_intervals I think succeeded in making the code much more readable, without slowing it down too much. I also removed some features that weren't being used: http://github.com/ctb/pygr/commit/3cb89fcf0470319dc839324a8fd799bcde8598d5 http://github.com/ctb/pygr/commit/5369a2136fd261fd63897760cfd86907401194fd I did a bit of tricky refactoring and swapped the AttributeInterface gender-bending code out for a function; let me know what you think. http://github.com/ctb/pygr/commit/5abb23d642fae02d105dedbd3a22a8a001766ac1 In the process I may have found a "bug" of sorts, noted with '@CTB'. All of this should be functionality-neutral. cheers, --titus -- C. Titus Brown, c...@msu.edu --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to pygr-dev@googlegroups.com To unsubscribe from this group, send email to pygr-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
