Hi Eden, I read through your four modules. The code is clean and explicit. The documentation is well written. It is very maintainable!
I noticed, however, your testing datasets are all very small (less than 5 entries each). Have you tried any of your module on larger datasets? If you have a psl file, for example, that contains ~100,000 entries. Reading this entire psl file into memory and keeping well over 100,000 alignment-interval objects in the memory might not give good performance. Thanks, Jenny On Wed, Aug 5, 2009 at 8:17 AM, C. Titus Brown <[email protected]> wrote: > > On Wed, Aug 05, 2009 at 01:36:55AM -0400, [email protected] wrote: > -> I have been working on adding pygr interfaces to various alignment > programs. It is one of the > -> projects in the GSOC09. The main message of this e-mail is to get > feedback on this project/my work. > -> > -> The project's public repository is at : > -> > -> http://github.com/eloseden/pygr-align/tree/master > > Hi all, > > I've been helping Eden out with this, and we'd both really appreciate > some general feedback. I haven't gone through this latest code in > detail yet, so I'll probably have detailed comments for her later, but > what I'd like to hear from the community is: > > - how should this be distributed and maintained? as part of pygr, > or...? > > - is the documentation adequate? > > - what other features do you want? > > thanks, > --titus > -- > C. Titus Brown, [email protected] > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
