On Fri, 10 Aug 2007 09:50:10 +0200
Christophe Berger <[EMAIL PROTECTED]> wrote:
> I experienced problems with pygresql while using the pg module.
> It does not quote the column names as (apparently) required in
> postgresql with mixed-case column names.
> 
> Here is a diff of my modifications :
> ~$ diff /usr/lib/python2.4/site-packages/pg.py ./mypg.py
> 418c418
> <                               n.append(f)
> ---
> >                               n.append('"%s"'%f)

Looks like a reasonable change.  I am going to commit this fi.  In
future though I would ask for two things.  First, context diffs are
preferred although this case is simple enough that it didn't matter.
Second, we like to add unit tests for every modification.  I have
created one for this case.  See the CVS commit message that will follow
this for details.

Thanks.

-- 
D'Arcy J.M. Cain
PyGreSQL Development Group
http://www.PyGreSQL.org
_______________________________________________
PyGreSQL mailing list
[email protected]
http://mailman.vex.net/mailman/listinfo/pygresql

Reply via email to