Am 08.01.2013 15:47, schrieb [email protected]:
Put the attributes one per line to make it easier to add and remove them. It will also make future changes easier to see in the diffs. Remove when_notified attribute.
Seems I forgot to run the tests or ran them against the wrong version. Good you caught that.
I prefer to keep the code more compact to avoid scrolling and let the editor wrap such long strings (e.g. you can use gq in vi), so for me it was even easier to have it that way. But concerning diff you're right.
And concerning scrolling, when this becomes a problem this actually indicates that the files are too large. When refactoring the tests we should spread them over several smaller files in a test directory rather than stuffing everything in one huge file, and start using unittest2 which has test discovery.
-- Christoph _______________________________________________ PyGreSQL mailing list [email protected] https://mail.vex.net/mailman/listinfo.cgi/pygresql
