Author: cito
Date: Sat Nov 21 12:26:50 2015
New Revision: 575

Log:
Don't use eval() if not necessary

Modified:
   trunk/module/TEST_PyGreSQL_classic_connection.py

Modified: trunk/module/TEST_PyGreSQL_classic_connection.py
==============================================================================
--- trunk/module/TEST_PyGreSQL_classic_connection.py    Sat Nov 21 11:43:13 
2015        (r574)
+++ trunk/module/TEST_PyGreSQL_classic_connection.py    Sat Nov 21 12:26:50 
2015        (r575)
@@ -79,9 +79,10 @@
     def testAllConnectAttributes(self):
         attributes = '''db error host options port
             protocol_version server_version status tty user'''.split()
-        connection_attributes = [a for a in dir(self.connection)
+        connection = self.connection
+        connection_attributes = [a for a in dir(connection)
             if not a.startswith('__')
-            and not callable(eval("self.connection." + a))]
+            and not callable(getattr(connection, a))]
         self.assertEqual(attributes, connection_attributes)
 
     def testAllConnectMethods(self):
@@ -90,9 +91,10 @@
             fileno get_notice_receiver getline getlo getnotify
             inserttable locreate loimport parameter putline query reset
             set_notice_receiver source transaction'''.split()
-        connection_methods = [a for a in dir(self.connection)
+        connection = self.connection
+        connection_methods = [a for a in dir(connection)
             if not a.startswith('__')
-            and callable(eval("self.connection." + a))]
+            and callable(getattr(connection, a))]
         self.assertEqual(methods, connection_methods)
 
     def testAttributeDb(self):
_______________________________________________
PyGreSQL mailing list
[email protected]
https://mail.vex.net/mailman/listinfo.cgi/pygresql

Reply via email to