Am 08.07.2018 um 18:29 schrieb D'Arcy Cain:
> OK by me.  I just installed 3.7 so I can do some testing.

Forgot to mention that I already ran the tests with Python 3.7 on Windows and Linux, everything worked fine.

> I don't see why this at least couldn't work without "with_names".

Sure, we could return named tuples by default, or even a hybrid object that could also be accessed as dict. Then we wouldn't need that distinction between various flavors of results. Maybe it would be the most elegant solution. But of course there would be some memory overhead compared with plain tuple/dict objects. And there might be problems when pickling rows or converting to JSON (for a hybrid object it's unclear whether dumps should give an array or an object with keys).

> Overall I am good with it.  One question - would "print(query) still
> display the result in tabular form?

In earlier versions that happened only when your actually printed the result. This was implemented using tp_print which is not supported any more in Python 3. Therefore PyGreSQL 5 does this conversion to tabular form already when converting the query to a string.

-- Christoph
_______________________________________________
PyGreSQL mailing list
PyGreSQL@vex.net
https://mail.vex.net/mailman/listinfo.cgi/pygresql

Reply via email to