On Sat, Jan 05, 2019 at 10:13:41PM +0100, Christoph Zwerschke wrote: > Am 05.01.2019 um 17:42 schrieb Justin Pryzby: > >On Fri, Jan 04, 2019 at 11:44:47PM +0100, Christoph Zwerschke wrote: > >There's a few remaining chunks which I think are improvements. Please review > >and apply your best judgement and standards :) > > Ok, thank you. See last commit message.
Thank you. Looks like this hunk was accidentally included: +All changes made by the transaction become visible to others. +=> Don't say this, since it's not true eg. in repeatable_read xtn +After returning, the changes are guaranteed to be durable, even if a crash occurs. +=> Don't say this since it's postgres job to document DB behavior, +kernel and library folks job to do their part, and DBA+sysadmin job to +implement it on site, not pygres or the developer's job +(with my developer's hat off and sysadmin hat on). While looking I also noticed this changelog seems to have a typo: |DB wrapper objects based on existing connections can not be closed and can NOW ? Thanks for maintaing pygres. Justin _______________________________________________ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
