On Sat, Jun 20, 2020 at 03:10:02PM +0200, Christoph Zwerschke wrote: > Am 20.06.2020 um 04:02 schrieb Justin Pryzby: > > I'm attaching my WIP patch. It will needs to be cleaned up, since (1) and > > (2) > > will surely cause rebase conflicts, so this is just a POC. > > Thank you. I have commited this after making a few amendments: > https://github.com/PyGreSQL/PyGreSQL/commit/f82d4cd20dfa66ec791091581e60e299b329c70e
Thank you ``columns`` is a optional sequence of column names to be passed on => *an* optional > This works with Python 2 and 3 now (we will drop Python 2 support probably > in version 6, but for now we must stay compatible). > > Escaping the table and column names was a > good idea (you must free the space for the escaped name though). I think you could have just as well said the opposite (passing the column names in the unesaped table names was a bad idea), since I was on the verge of suggesting we just do document that :) > Does my commit cover everything you mentioned, can we close the issue? I think it's done - thanks for finishing it. -- Justin _______________________________________________ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
