On lun, 2008-12-22 at 18:20 +0100, Lorenzo Mancini wrote: > Lorenzo Mancini wrote: > > I'm attaching a pyinstaller hook for PyOpenGL which builds and improves > > on the one posted by Oscar a few days ago. Namely: > > ...and thinking a little more about it, it doesn't make really sense to > RuntimeError when PyOpenGL version doesn't match; if it's a <=3.0.0b6 > PyOpenGL it's not going to work anyway, and if it's an older 2.x > version, those used to work as-is under pyinstaller. > > I'm attaching the updated version.
The version check is useless as well: if you have an older version (eg: v2) those modules will not exist and this does not do any harm (except false positives among missing modules). But you should never import a module within its hook, so this is a non-starter. If you look at hook-xml, you will see that it executes a subprocess to check the pyxml version: that's the way to do it. -- Giovanni Bajo Develer S.r.l. http://www.develer.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/PyInstaller?hl=en -~----------~----~----~----~------~----~------~--~---
