On Mon, 2010-12-06 at 11:42 -0500, Nathan Weston wrote: > On 12/6/2010 11:12 AM, Isaac Wagner wrote: > > Shouldn't the comparison be 2**31 instead of 3**32? > > > Oops, typo there. The left side should obviously be 2, not 3. > > But I intentionally used 32 for the exponent, not 31. My thinking was > that on some hypothetical system, sys.maxint might be the maximum > unsigned int (not likely, but who knows?), so it was safer to use 32. We > don't need to be terribly precise since 64-bit maxint is many orders of > magnitude larger. > > > The fails for me on Win64 with a 64-bit Python install. For some > > reason sys.maxint returns the same on my Win32 or Win64 boxes. > > That's inconvenient. I guess we should stick with > platform.architecture() on non-Mac platforms. > > I've attached a new patch that incorporates both these fixes.
Thanks, committed with slight changes in -rc2 (which I'm going to release soon). One change was to use 2L instead of 2, to cope with older Python versions which don't mute int into long in case of overflow. -- Giovanni Bajo :: [email protected] Develer S.r.l. :: http://www.develer.com My Blog: http://giovanni.bajo.it Last post: Compile-time Function Execution in D -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyinstaller?hl=en.
