Daniel Hyams píše v Ne 07. 04. 2013 v 20:15 -0400:
> I've added the ability for the bootloader to watch for OpenDocument
> Apple events; this lets the bootloader intercept the events and add
> the relevant incoming files to sys.argv.  This lets apps that are run
> via a double-click of an associated data file function correctly.  The
> only files modified are bootloader/common/main.c and a small change to
> "wscript".

> Anyway, I'd like to issue a pull request, but I'm not sure which
> branch to issue against.  The version of pyinstaller that I modified
> to add the patch to is matysek's "develop" branch.   So, that one
> would be the easiest, but I realize that if I issue against that,
> matysek would have to pull it, and then it might eventually make it
> into the regular pyinstaller develop branch.  Note that the main.c
> source code between matysek/pyinstaller and pyinstaller/pyinstaller
> looks very different.

It should not look much different. I try to regularly merge my changes
to pyinstaller develop branch. The following merge request are my only
changes that are missing in pyinstaller develop branch:

https://github.com/pyinstaller/pyinstaller/pull/48

> Then there's the pyinstaller "develop" and "master" branches.  Which
> are also possibilities.

"master" branch is the place where you get code of the latest stable
release - not good choice for new code.

> Which would be the best to do here?  Or maybe I should just hold off
> until matysek's develop branch is merged in?

Best option should be the directly the pyinstaller 'develop' branch.

Could you please do the pull request without recompiled bootloader for
osx?

Are those just minor (osx specific) changes so that they could be
included with next release 2.1?

Could you provide more information and/or examples about the feature you
implemented so that the manual could be updated according to your
changes?

Thanks for your work.



-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/pyinstaller?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to