I brought it to a state of working, in the sense that it collects the same set of files that 2.1 collects. Changes were only in the area of collecting the set of files to include; all the following work of building the bundle was unchanged. My code is in a branch that can be found at the pyinstaller github stite.
Two areas need more work. First, Modulegraph does not distinguish between conditional imports and non-conditional ones. So there is a warning message that cannot be issued. (pyinstaller cannot say that a missing import was conditional; it was just missing.) I opened an issue at Modulegraph's site on this (you commented on that issue recently, yes?). The Modulegraph owner replied once briefly and has not communicated since. (I am suspicious that Modulegraph is not getting much attention any more. Hope I am wrong.) Second area: in order to make my changes work, I had to modify hook code somewhat. This is because (a) the hook is no longer called with a genuine Module object, but rather a simpler object that I faked up. [and that was because (i) I didn't understand Module objects well and (ii) Modulegraph doesn't use them either] Also (b) different information is available at hook-calling time, and different things are done with the values set by the hook. So: all hooks need to be reviewed and tested, and some (not all) need to have a bit of code added to test whether they received a real Module from pyinstaller 2.1, or a fake module from the Modulegraph version. So that's where I left it. I would delighted if you or anyone can carry it forward. I'll be glad to answer any questions. Dave Cortesi On Wednesday, February 26, 2014 8:36:08 AM UTC-8, Hartmut Goebel wrote: > > Hi, > > I'm wondering what is the state of the modulegraph integration. I > completely lost where we are. > > What is working, what not? Does it work with Python 2.x? What are the next > steps? > > > > -- > Schönen Gruß > Hartmut Goebel > Dipl.-Informatiker (univ), CISSP, CSSLP > Information Security Management, Security Governance, Secure Software > Development > > Goebel Consult, Landshut > http://www.goebel-consult.de > > Blog: http://www.goebel-consult.de/blog/1.-platz-bei-google-ganz-ohne-seo > Kolumne: > http://www.cissp-gefluester.de/2012-09-steht-ein-manta-fahrer-vor-der-uni > > Goebel Consult ist Mitglied bei http://www.7-it.de/ > -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/pyinstaller. For more options, visit https://groups.google.com/groups/opt_out.
