In surveying the existing hooks I noticed some odd things. In coming days I
mean to read some of the code and may be able to find some answers that
way, but still, I'd appreciate any comment on these.

Six of the hook-xml* files assign values to an attrs global, as if this had
some meaning. Does a global attrs mean anything in the current hook API?

hook-wx.lib.activex.py contains only the following:

        exec_statement("import wx.lib.activex")

That's it! How can this can do anything useful to the app being built?

hook-PySide.QtCore.py assigns an empty list to hiddenimports. It assigns a
nonempty list to binaries also. But is there any reason not to delete that
assignment of an empty list?

hook-Xlib.py has imports of sys and PyInstaller.is_unix which are not used.
Delete?

hook-markdown.py imports collect_data_files but doesn't call it. Ok to
delete?

Thanks for any comments,
Dave Cortesi

-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/pyinstaller.
For more options, visit https://groups.google.com/d/optout.

Reply via email to