Surveying existing hooks, I wrote,

> Only 4 hooks assign to excludedimports.

to which Hartmut G. replied,

> These need to be converted into pre-safe-import hooks, I assume.

I am only now looking closely at the code to call any 
pre_safe_import_module() type of hook. It appears the purpose of these is 
to add nodes to the Modulegraph, because Modulegraph will not detect 
dynamically-created imports. That is what the existing hooks (gi.repository 
and six.moves) do.

How does this -- ADDING nodes -- relate to the excludedimports global which 
is about REMOVING nodes?

Does this mean that excludedimports no longer works?

OH NOZE! (insert picture of kitten with paws over its eyes)

I am doing a multifile search and the word "excludedimports" no longer 
appears anywhere except in those 4 hooks and the manual! 

In particular it does not appear in Analysis.py. AGGGHHHHH! (Insert "The 
Scream" emoji)

Enlightenment desperately needed here...



-- 
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/pyinstaller.
For more options, visit https://groups.google.com/d/optout.

Reply via email to